]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/core: put ops-handled filters to damos->ops_filters
authorSeongJae Park <sj@kernel.org>
Tue, 4 Mar 2025 21:19:08 +0000 (13:19 -0800)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Mar 2025 07:05:38 +0000 (00:05 -0700)
damos->ops_filters has introduced to be used for all operations layer
handled filters.  But DAMON kernel API callers can put any type of DAMOS
filters to any of damos->filters and damos->ops_filters.  DAMON user-space
ABI users have no way to use ->ops_filters at all.  Update
damos_add_filter(), which should be used by API callers to install DAMOS
filters, to add filters to ->filters and ->ops_filters depending on their
handling layer.  The change forces both API callers and ABI users to use
proper lists since ABI users use the API internally.

Link: https://lkml.kernel.org/r/20250304211913.53574-5-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index 1daccccb5d67b54b0059572a6f6627c4e5da08e3..3fbc31d172396f80f29dfdd95114610ced67cea5 100644 (file)
@@ -281,9 +281,24 @@ struct damos_filter *damos_new_filter(enum damos_filter_type type,
        return filter;
 }
 
+static bool damos_filter_for_ops(enum damos_filter_type type)
+{
+       switch (type) {
+       case DAMOS_FILTER_TYPE_ADDR:
+       case DAMOS_FILTER_TYPE_TARGET:
+               return false;
+       default:
+               break;
+       }
+       return true;
+}
+
 void damos_add_filter(struct damos *s, struct damos_filter *f)
 {
-       list_add_tail(&f->list, &s->filters);
+       if (damos_filter_for_ops(f->type))
+               list_add_tail(&f->list, &s->ops_filters);
+       else
+               list_add_tail(&f->list, &s->filters);
 }
 
 static void damos_del_filter(struct damos_filter *f)