]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
leds: pca9532: Remove irrelevant blink configuration error message
authorBastien Curutchet <bastien.curutchet@bootlin.com>
Mon, 26 Aug 2024 13:32:37 +0000 (15:32 +0200)
committerLee Jones <lee@kernel.org>
Fri, 30 Aug 2024 08:01:08 +0000 (09:01 +0100)
The update_hw_blink() function prints an error message when hardware is
not able to handle a blink configuration on its own. IMHO, this isn't a
'real' error since the software fallback is used afterwards.

Remove the error messages to avoid flooding the logs with unnecessary
messages.

Cc: stable@vger.kernel.org
Fixes: 48ca7f302cfc ("leds: pca9532: Use PWM1 for hardware blinking")
Signed-off-by: Bastien Curutchet <bastien.curutchet@bootlin.com>
Link: https://lore.kernel.org/r/20240826133237.134604-1-bastien.curutchet@bootlin.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-pca9532.c

index 338ddada3de9d16b19f9fccd29cad94615ba9adb..1b47acf54720b314772c2c21af6357845b5a16be 100644 (file)
@@ -215,8 +215,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led,
                if (other->state == PCA9532_PWM1) {
                        if (other->ldev.blink_delay_on != delay_on ||
                            other->ldev.blink_delay_off != delay_off) {
-                               dev_err(&led->client->dev,
-                                       "HW can handle only one blink configuration at a time\n");
+                               /* HW can handle only one blink configuration at a time */
                                return -EINVAL;
                        }
                }
@@ -224,7 +223,7 @@ static int pca9532_update_hw_blink(struct pca9532_led *led,
 
        psc = ((delay_on + delay_off) * PCA9532_PWM_PERIOD_DIV - 1) / 1000;
        if (psc > U8_MAX) {
-               dev_err(&led->client->dev, "Blink period too long to be handled by hardware\n");
+               /* Blink period too long to be handled by hardware */
                return -EINVAL;
        }