]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: mt65xx: fix controller deregistration
authorJohan Hovold <johan@kernel.org>
Fri, 10 Apr 2026 08:17:31 +0000 (10:17 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 10 Apr 2026 12:22:24 +0000 (13:22 +0100)
Make sure to deregister the controller before disabling underlying
resources like clocks during driver unbind.

Fixes: a568231f4632 ("spi: mediatek: Add spi bus for Mediatek MT8173")
Cc: stable@vger.kernel.org # 4.3: ace145802350
Cc: stable@vger.kernel.org # 4.3
Cc: Leilk Liu <leilk.liu@mediatek.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260410081757.503099-2-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-mt65xx.c

index 0368a26bca9ab7ffcba2ca4edf2f03df10523bc3..96f8555be98346ae3982d78fa0c63c1c05b8bbbc 100644 (file)
@@ -1325,7 +1325,7 @@ static int mtk_spi_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
 
-       ret = devm_spi_register_controller(dev, host);
+       ret = spi_register_controller(host);
        if (ret) {
                pm_runtime_disable(dev);
                return dev_err_probe(dev, ret, "failed to register host\n");
@@ -1340,6 +1340,8 @@ static void mtk_spi_remove(struct platform_device *pdev)
        struct mtk_spi *mdata = spi_controller_get_devdata(host);
        int ret;
 
+       spi_unregister_controller(host);
+
        cpu_latency_qos_remove_request(&mdata->qos_request);
        if (mdata->use_spimem && !completion_done(&mdata->spimem_done))
                complete(&mdata->spimem_done);