]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gccrs: parser: Improve parsing of complex generic arguments
authorArthur Cohen <arthur.cohen@embecosm.com>
Wed, 1 Feb 2023 11:41:47 +0000 (12:41 +0100)
committerArthur Cohen <arthur.cohen@embecosm.com>
Thu, 6 Apr 2023 08:47:19 +0000 (10:47 +0200)
The parser was missing code for handling complex type arguments such
as type paths or nested generics.

gcc/rust/ChangeLog:

* parse/rust-parse-impl.h (Parser::parse_generic_arg): Handle type
paths and nested generics properly.

gcc/testsuite/ChangeLog:

* rust/compile/parse_complex_generic_application.rs: New test.
* rust/compile/parse_complex_generic_application2.rs: New test.

gcc/rust/parse/rust-parse-impl.h
gcc/testsuite/rust/compile/parse_complex_generic_application.rs [new file with mode: 0644]
gcc/testsuite/rust/compile/parse_complex_generic_application2.rs [new file with mode: 0644]

index 23b033fb26e6708db19805c74a2a1cfc1352c648..3610790815c25720d34f59a6a8fa4fa279652fe5 100644 (file)
@@ -6309,7 +6309,9 @@ Parser<ManagedTokenSource>::parse_generic_arg ()
        // could either have a valid type or a macro (FIXME: anything else?). So
        // we need one bit of lookahead to differentiate if this is really
        auto next_tok = lexer.peek_token (1);
-       if (next_tok->get_id () == EXCLAM)
+       if (next_tok->get_id () == LEFT_ANGLE
+           || next_tok->get_id () == SCOPE_RESOLUTION
+           || next_tok->get_id () == EXCLAM)
          {
            auto type = parse_type ();
            if (type)
diff --git a/gcc/testsuite/rust/compile/parse_complex_generic_application.rs b/gcc/testsuite/rust/compile/parse_complex_generic_application.rs
new file mode 100644 (file)
index 0000000..d5c7bf4
--- /dev/null
@@ -0,0 +1,17 @@
+pub enum Either<T, E> {
+    Left(T),
+    Right(E),
+}
+
+pub mod err {
+    pub struct Error;
+    pub struct ErrorWrap<T>(T);
+}
+
+pub fn foo_err() -> Either<(), err::Error> {
+    Either::Left(())
+}
+
+pub fn foo_err_wrap() -> Either<(), err::ErrorWrap<u8>> {
+    Either::Left(())
+}
diff --git a/gcc/testsuite/rust/compile/parse_complex_generic_application2.rs b/gcc/testsuite/rust/compile/parse_complex_generic_application2.rs
new file mode 100644 (file)
index 0000000..0361931
--- /dev/null
@@ -0,0 +1,10 @@
+pub enum Either<L, R> {
+    Left(L),
+    Right(R),
+}
+
+pub struct Wrap<T>(T);
+
+pub fn foo_wrap() -> Either<(), Wrap<u8>> {
+    Either::Left(())
+}