]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: Kconfig: discourage drop_monitor enablement
authorFlorian Westphal <fw@strlen.de>
Thu, 16 Oct 2025 11:51:47 +0000 (13:51 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 17 Oct 2025 23:29:26 +0000 (16:29 -0700)
Quoting Eric Dumazet:
"I do not understand the fascination with net/core/drop_monitor.c [..]
misses all the features, flexibility, scalability  that 'perf',
eBPF tracing, bpftrace, .... have today."

Reword DROP_MONITOR kconfig help text to clearly state that its not
related to perf-based drop monitoring and that its safe to disable
this unless support for the older netlink-based tools is needed.

Signed-off-by: Florian Westphal <fw@strlen.de>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20251016115147.18503-1-fw@strlen.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/Kconfig

index 1d3f757d4b07e0ac9640d9cf5871f6a9f9c97e90..62266eaf0e95ac344e42d9a0fb23bbcd86f791e3 100644 (file)
@@ -400,15 +400,15 @@ config NET_PKTGEN
          module will be called pktgen.
 
 config NET_DROP_MONITOR
-       tristate "Network packet drop alerting service"
+       tristate "Legacy network packet drop alerting service"
        depends on INET && TRACEPOINTS
        help
          This feature provides an alerting service to userspace in the
          event that packets are discarded in the network stack.  Alerts
          are broadcast via netlink socket to any listening user space
-         process.  If you don't need network drop alerts, or if you are ok
-         just checking the various proc files and other utilities for
-         drop statistics, say N here.
+         process. This feature is NOT related to "perf" based drop monitoring.
+         Say N here unless you need to support older userspace tools like
+         "dropwatch".
 
 endmenu # Network testing