]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
cifs: get rid of @noreq param in __dfs_cache_find()
authorPaulo Alcantara <pc@cjr.nz>
Fri, 4 Jun 2021 22:25:28 +0000 (19:25 -0300)
committerSteve French <stfrench@microsoft.com>
Mon, 21 Jun 2021 02:28:16 +0000 (21:28 -0500)
@noreq param isn't used anywhere, so just remove it.

Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Reviewed-by: Aurelien Aptel <aaptel@suse.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/dfs_cache.c

index 03c81c39a507a190d7d34f68632d776ff0d62a8c..70383e14ca4ae3d4fb7144e136d36898a582e993 100644 (file)
@@ -690,8 +690,7 @@ static int update_cache_entry(const char *path,
  * handle them properly.
  */
 static int __dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
-                           const struct nls_table *nls_codepage, int remap,
-                           const char *path, bool noreq)
+                           const struct nls_table *nls_codepage, int remap, const char *path)
 {
        int rc;
        unsigned int hash;
@@ -705,16 +704,6 @@ static int __dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
        down_read(&htable_rw_lock);
 
        ce = lookup_cache_entry(path, &hash);
-
-       /*
-        * If @noreq is set, no requests will be sent to the server. Just return
-        * the cache entry.
-        */
-       if (noreq) {
-               up_read(&htable_rw_lock);
-               return PTR_ERR_OR_ZERO(ce);
-       }
-
        if (!IS_ERR(ce)) {
                if (!cache_entry_expired(ce)) {
                        dump_ce(ce);
@@ -879,7 +868,7 @@ int dfs_cache_find(const unsigned int xid, struct cifs_ses *ses,
        if (rc)
                return rc;
 
-       rc = __dfs_cache_find(xid, ses, nls_codepage, remap, npath, false);
+       rc = __dfs_cache_find(xid, ses, nls_codepage, remap, npath);
        if (rc)
                goto out_free_path;
 
@@ -991,7 +980,7 @@ int dfs_cache_update_tgthint(const unsigned int xid, struct cifs_ses *ses,
 
        cifs_dbg(FYI, "%s: update target hint - path: %s\n", __func__, npath);
 
-       rc = __dfs_cache_find(xid, ses, nls_codepage, remap, npath, false);
+       rc = __dfs_cache_find(xid, ses, nls_codepage, remap, npath);
        if (rc)
                goto out_free_path;