]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/damon/tests/vaddr-kunit: handle alloc failures on damon_do_test_apply_three_regions()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:20:11 +0000 (11:20 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Mon, 17 Nov 2025 01:28:34 +0000 (17:28 -0800)
damon_do_test_apply_three_regions() is assuming all dynamic memory
allocation in it will succeed.  Those are indeed likely in the real use
cases since those allocations are too small to fail, but theoretically
those could fail.  In the case, inappropriate memory access can happen.
Fix it by appropriately cleanup pre-allocated memory and skip the
execution of the remaining tests in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-18-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/tests/vaddr-kunit.h

index fce38dd53cf8f81ed94abcb1582df996e93f0fbd..484223f195459d25097f0853245bcf211d4c469c 100644 (file)
@@ -136,8 +136,14 @@ static void damon_do_test_apply_three_regions(struct kunit *test,
        int i;
 
        t = damon_new_target();
+       if (!t)
+               kunit_skip(test, "target alloc fail");
        for (i = 0; i < nr_regions / 2; i++) {
                r = damon_new_region(regions[i * 2], regions[i * 2 + 1]);
+               if (!r) {
+                       damon_destroy_target(t, NULL);
+                       kunit_skip(test, "region alloc fail");
+               }
                damon_add_region(r, t);
        }