]> git.ipfire.org Git - thirdparty/nftables.git/commitdiff
expression: missing line in describe command with invalid expression
authorPablo Neira Ayuso <pablo@netfilter.org>
Tue, 13 Feb 2024 16:09:20 +0000 (17:09 +0100)
committerPablo Neira Ayuso <pablo@netfilter.org>
Tue, 13 Feb 2024 16:23:55 +0000 (17:23 +0100)
Before:

 duh@testbed:~# nft describe blah
 symbol expression, datatype invalid (invalid)duh@testbed:#

After:

 duh@testbed:~# nft describe blah
 symbol expression, datatype invalid (invalid)
 duh@testbed:#

Fixes: 48aca2de80a7 ("iptopt: fix crash with invalid field/type combo")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
src/expression.c

index dde48b6aa0027e1c92a3d8b22f633d55f70df1b6..cb2573fec4576ab267c872f85e99b1842134d758 100644 (file)
@@ -140,8 +140,10 @@ void expr_describe(const struct expr *expr, struct output_ctx *octx)
                nft_print(octx, "%s expression, datatype %s (%s)",
                          expr_name(expr), dtype->name, dtype->desc);
 
-               if (dtype == &invalid_type)
+               if (dtype == &invalid_type) {
+                       nft_print(octx, "\n");
                        return;
+               }
        }
 
        if (dtype->basetype != NULL) {