]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
dma-buf: fix incorrect dma-fence documentation v2
authorChristian König <christian.koenig@amd.com>
Tue, 10 Dec 2024 09:08:42 +0000 (10:08 +0100)
committerChristian König <christian.koenig@amd.com>
Thu, 6 Mar 2025 14:20:43 +0000 (15:20 +0100)
There isn't much worse than documentation giving an incorrect advise.
Grabbing a spinlock while interrupts are disabled usually means that you
must also disable interrupts for all other uses of this spinlock.

Otherwise really hard to debug issues can occur. So fix that invalid
documentation.

v2: use Dmitry's suggestion on the documentation

Signed-off-by: Christian König <christian.koenig@amd.com>
Reviewed-by: Simona Vetter <simona.vetter@ffwll.ch> (v1)
Link: https://patchwork.freedesktop.org/patch/msgid/20250211163109.12200-2-christian.koenig@amd.com
include/linux/dma-fence.h

index e7ad819962e3edaac9cdad3b4d2de78a6c705971..52587d390acab45e552fd5eb33e6c2ae5e39652c 100644 (file)
@@ -169,8 +169,8 @@ struct dma_fence_ops {
         * implementation know that there is another driver waiting on the
         * signal (ie. hw->sw case).
         *
-        * This function can be called from atomic context, but not
-        * from irq context, so normal spinlocks can be used.
+        * This is called with irq's disabled, so only spinlocks which disable
+        * IRQ's can be used in the code outside of this callback.
         *
         * A return value of false indicates the fence already passed,
         * or some failure occurred that made it impossible to enable