]> git.ipfire.org Git - thirdparty/psycopg.git/commitdiff
refactor: check if cancel safe is implemented via capabilities
authorDaniele Varrazzo <daniele.varrazzo@gmail.com>
Fri, 12 Apr 2024 22:36:36 +0000 (00:36 +0200)
committerDaniele Varrazzo <daniele.varrazzo@gmail.com>
Wed, 17 Apr 2024 21:51:20 +0000 (23:51 +0200)
psycopg/psycopg/connection.py
psycopg/psycopg/connection_async.py

index 9701770d8d800ec13d7e78de997e54007a713a4c..12c06993abea001279d29e86407bad6df170081a 100644 (file)
@@ -32,6 +32,7 @@ from ._encodings import pgconn_encoding
 from .generators import notifies
 from .transaction import Transaction
 from .cursor import Cursor
+from ._capabilities import capabilities
 from .server_cursor import ServerCursor
 from ._connection_base import BaseConnection, CursorRow, Notify
 
@@ -277,8 +278,7 @@ class Connection(BaseConnection[Row]):
         if not self._should_cancel():
             return
 
-        # TODO: replace with capabilities.has_safe_cancel after merging #782
-        if pq.__build_version__ >= 170000:
+        if capabilities.has_cancel_safe():
             try:
                 waiting.wait_conn(
                     self._cancel_gen(timeout=timeout), interval=_WAIT_INTERVAL
index beb4c8714dfc1db8b46d3bfb2e8ad166d7b3e5ad..096213a1b96af7b21ba2144d73f80ef83d392d99 100644 (file)
@@ -29,6 +29,7 @@ from ._encodings import pgconn_encoding
 from .generators import notifies
 from .transaction import AsyncTransaction
 from .cursor_async import AsyncCursor
+from ._capabilities import capabilities
 from .server_cursor import AsyncServerCursor
 from ._connection_base import BaseConnection, CursorRow, Notify
 
@@ -294,8 +295,7 @@ class AsyncConnection(BaseConnection[Row]):
         if not self._should_cancel():
             return
 
-        # TODO: replace with capabilities.has_safe_cancel after merging #782
-        if pq.__build_version__ >= 170000:
+        if capabilities.has_cancel_safe():
             try:
                 await waiting.wait_conn_async(
                     self._cancel_gen(timeout=timeout), interval=_WAIT_INTERVAL