]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: Fix reset-gpios property on brcm BT nodes
authorDiederik de Haas <didi.debian@cknow.org>
Tue, 8 Oct 2024 11:15:39 +0000 (13:15 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Tue, 8 Oct 2024 19:17:23 +0000 (21:17 +0200)
For most compatibles, the "brcm,bluetooth.yaml" binding doesn't allow
the 'reset-gpios' property, but there is a 'shutdown-gpios' property.

Page 12 of the AzureWave-CM256SM datasheet (v1.9) has the following wrt
pin 34 'BT_REG_ON' (connected to GPIO0_C4_d on the PineNote):

  Used by PMU to power up or power down the internal regulators used
  by the Bluetooth section. Also, when deasserted, this pin holds the
  Bluetooth section in reset. This pin has an internal 200k ohm pull
  down resistor that is enabled by default.

So it is safe to replace 'reset-gpios' with 'shutdown-gpios'.

Fixes: d449121e5e8a ("arm64: dts: rockchip: Add Pine64 PineNote board")
Signed-off-by: Diederik de Haas <didi.debian@cknow.org>
Link: https://lore.kernel.org/r/20241008113344.23957-5-didi.debian@cknow.org
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3566-pinenote.dtsi
arch/arm64/boot/dts/rockchip/rk3566-radxa-cm3.dtsi

index ca7666bf5c0a50d2744268b278edc6b22aa7be5f..a477bd992b40e18e609bfeb1225729353f102880 100644 (file)
                clock-names = "lpo";
                device-wakeup-gpios = <&gpio0 RK_PC2 GPIO_ACTIVE_HIGH>;
                host-wakeup-gpios = <&gpio0 RK_PC3 GPIO_ACTIVE_HIGH>;
-               reset-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>;
                pinctrl-0 = <&bt_enable_h>, <&bt_host_wake_l>, <&bt_wake_h>;
                pinctrl-names = "default";
+               shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_LOW>;
                vbat-supply = <&vcc_wl>;
                vddio-supply = <&vcca_1v8_pmu>;
        };
index 45de2630bb503ae1d20fe6bc998477f73800ca7d..e9fa9bee995ae5835054a2f95d12da9585356f20 100644 (file)
                clock-names = "lpo";
                device-wakeup-gpios = <&gpio2 RK_PB2 GPIO_ACTIVE_HIGH>;
                host-wakeup-gpios = <&gpio2 RK_PB1 GPIO_ACTIVE_HIGH>;
-               reset-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&bt_host_wake_h &bt_reg_on_h &bt_wake_host_h>;
+               shutdown-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_LOW>;
                vbat-supply = <&vcc_3v3>;
                vddio-supply = <&vcc_1v8>;
        };