]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/vkms: Suppress context imbalance detected by sparse warning
authorLouis Chauvet <louis.chauvet@bootlin.com>
Thu, 12 Sep 2024 15:25:33 +0000 (17:25 +0200)
committerMaíra Canal <mcanal@igalia.com>
Tue, 24 Sep 2024 23:39:56 +0000 (20:39 -0300)
The functions `vkms_crtc_atomic_begin` and `vkms_crtc_atomic_flush` are
responsible for locking and unlocking a mutex, respectively. Add the
`__acquires` and `__releases` annotations to these functions to prevent
the associated sparse warning about context imbalance.

Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
Reviewed-by: José Expósito <jose.exposito89@gmail.com>
Signed-off-by: Maíra Canal <mcanal@igalia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240912-vkms-warnings-v1-1-59f3e13ea8e5@bootlin.com
drivers/gpu/drm/vkms/vkms_crtc.c

index 40b4d084e3ceef9e1e24b7338efdd9253afee8d6..2ad164b518fb93f5b6b86948116ff7ed97770b60 100644 (file)
@@ -232,6 +232,7 @@ static void vkms_crtc_atomic_disable(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
                                   struct drm_atomic_state *state)
+       __acquires(&vkms_output->lock)
 {
        struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);
 
@@ -243,6 +244,7 @@ static void vkms_crtc_atomic_begin(struct drm_crtc *crtc,
 
 static void vkms_crtc_atomic_flush(struct drm_crtc *crtc,
                                   struct drm_atomic_state *state)
+       __releases(&vkms_output->lock)
 {
        struct vkms_output *vkms_output = drm_crtc_to_vkms_output(crtc);