]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
closes bpo-34474: Python/bltinmodule.c: Add missing NULL check in builtin_sum_impl...
authorAlexey Izbyshev <izbyshev@ispras.ru>
Fri, 24 Aug 2018 04:27:52 +0000 (07:27 +0300)
committerBenjamin Peterson <benjamin@python.org>
Fri, 24 Aug 2018 04:27:52 +0000 (21:27 -0700)
Reported by Svace static analyzer.

Python/bltinmodule.c

index 4b12048f9d56928d564d69c22716d9d42e382fb6..8aa1ba01d659c8add1a210619384995dd3325fc3 100644 (file)
@@ -2401,6 +2401,11 @@ builtin_sum_impl(PyObject *module, PyObject *iterable, PyObject *start)
                 }
             }
             result = PyFloat_FromDouble(f_result);
+            if (result == NULL) {
+                Py_DECREF(item);
+                Py_DECREF(iter);
+                return NULL;
+            }
             temp = PyNumber_Add(result, item);
             Py_DECREF(result);
             Py_DECREF(item);