]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
memory: tegra124-emc: simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 16 Aug 2024 10:54:32 +0000 (12:54 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Wed, 21 Aug 2024 11:23:34 +0000 (13:23 +0200)
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240816-cleanup-h-of-node-put-memory-v2-8-9eed0ee16b78@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/memory/tegra/tegra124-emc.c

index 47c0c19e13fd5a3af043836d29119a4db5feed7b..03f1daa2d132a81d28705ec7c62d640d7d25a894 100644 (file)
@@ -992,7 +992,6 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc,
                                          struct device_node *node)
 {
        int child_count = of_get_child_count(node);
-       struct device_node *child;
        struct emc_timing *timing;
        unsigned int i = 0;
        int err;
@@ -1004,14 +1003,12 @@ static int tegra_emc_load_timings_from_dt(struct tegra_emc *emc,
 
        emc->num_timings = child_count;
 
-       for_each_child_of_node(node, child) {
+       for_each_child_of_node_scoped(node, child) {
                timing = &emc->timings[i++];
 
                err = load_one_timing_from_dt(emc, timing, child);
-               if (err) {
-                       of_node_put(child);
+               if (err)
                        return err;
-               }
        }
 
        sort(emc->timings, emc->num_timings, sizeof(*timing), cmp_timings,