]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: quic: wrong bbr_target_inflight() implementation
authorFrederic Lecaille <flecaille@haproxy.com>
Thu, 12 Dec 2024 10:44:10 +0000 (11:44 +0100)
committerFrederic Lecaille <flecaille@haproxy.com>
Fri, 13 Dec 2024 13:42:43 +0000 (14:42 +0100)
This bug arrived with this commit:

  6404b7a18a BUG/MINOR: quic: fix bbr_inflight() calls with wrong gain value

This patch partially reverts after having checked the BBR v3 draft.
This bug was invisible when testing long BBR flows.

Must be backported to 3.1.

src/quic_cc_bbr.c

index a164c1f3f2befd9d4c836835c2ecb11dc72a76e9..b08c4b5397a698e58d54ac3df0fb97f311b96807 100644 (file)
@@ -840,7 +840,7 @@ static void bbr_exit_probe_rtt(struct bbr *bbr)
 
 static uint64_t bbr_target_inflight(struct bbr *bbr, struct quic_cc_path *p)
 {
-       uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, bbr->cwnd_gain);
+       uint64_t bdp = bbr_inflight(bbr, p, bbr->bw, 100);
        return MIN(bdp, p->cwnd);
 }