support: Explain ignored failures of temporary file removal [BZ #21243]

diff --git a/ChangeLog b/ChangeLog
index c9a9a89827fa68777fc2d947b74cc2686fb02e4d..2d489f041a1298f22956f142fef4342c07c4fa42 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2017-03-15  Florian Weimer  <fweimer@redhat.com>
+
+       [BZ #21243]
+       * support/temp_file.c (support_delete_temp_files): Add comment
+       about ignored errors.
+
 2017-03-15  Florian Weimer  <fweimer@redhat.com>
 
        [BZ #21244]

diff --git a/support/temp_file.c b/support/temp_file.c
index f06647a467fbf39809a25acb28c78a61d02c29be..5950aec06b628080dd7373775db0b3cd9707448e 100644 (file)
--- a/support/temp_file.c
+++ b/support/temp_file.c
@@ -99,7 +99,10 @@ support_delete_temp_files (void)
 {
   while (temp_name_list != NULL)
     {
-      remove (temp_name_list->name);
+      /* For some tests, the temporary file removal runs multiple
+        times (in the parent processes and the subprocess), so do not
+        report a failed removal attempt.  */
+      (void) remove (temp_name_list->name);
       free (temp_name_list->name);
 
       struct temp_name_list *next