]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
selftests/powerpc: Fix argument order to timer_sub()
authorMichael Ellerman <mpe@ellerman.id.au>
Wed, 18 Dec 2024 11:43:47 +0000 (22:43 +1100)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Sat, 11 Jan 2025 05:09:45 +0000 (10:39 +0530)
Commit c814bf958926 ("powerpc/selftests: Use timersub() for
gettimeofday()"), got the order of arguments to timersub() wrong,
leading to a negative time delta being reported, eg:

  test: gettimeofday
  tags: git_version:v6.12-rc5-409-gdddf291c3030
  time = -3.297781
  success: gettimeofday

The correct order is minuend, subtrahend, which in this case is end,
start. Which gives:

  test: gettimeofday
  tags: git_version:v6.12-rc5-409-gdddf291c3030-dirty
  time = 3.300650
  success: gettimeofday

Fixes: c814bf958926 ("powerpc/selftests: Use timersub() for gettimeofday()")
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20241218114347.428108-1-mpe@ellerman.id.au
tools/testing/selftests/powerpc/benchmarks/gettimeofday.c

index 580fcac0a09f31bf284d46c97f25148c96909386..b71ef8a493ed1ab56ddc6f8b24fcfaa7079b6db5 100644 (file)
@@ -20,7 +20,7 @@ static int test_gettimeofday(void)
                gettimeofday(&tv_end, NULL);
        }
 
-       timersub(&tv_start, &tv_end, &tv_diff);
+       timersub(&tv_end, &tv_start, &tv_diff);
 
        printf("time = %.6f\n", tv_diff.tv_sec + (tv_diff.tv_usec) * 1e-6);