]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/net/cadence_gem: fix register mask initialization
authorLuc Michel <luc.michel@amd.com>
Wed, 16 Jul 2025 09:53:43 +0000 (11:53 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Tue, 29 Jul 2025 11:56:39 +0000 (13:56 +0200)
The gem_init_register_masks function was called at init time but it
relies on the num-priority-queues property. Call it at realize time
instead.

Cc: qemu-stable@nongnu.org
Fixes: 4c70e32f05f ("net: cadence_gem: Define access permission for interrupt registers")
Signed-off-by: Luc Michel <luc.michel@amd.com>
Reviewed-by: Francisco Iglesias <francisco.iglesias@amd.com>
Reviewed-by: Sai Pavan Boddu <sai.pavan.boddu@amd.com>
Message-ID: <20250716095432.81923-2-luc.michel@amd.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
hw/net/cadence_gem.c

index 50025d5a6f2b35882a5948e82872863bc966e3d5..44446666deb26652cb79c9a24bc39329b04feb69 100644 (file)
@@ -1756,6 +1756,7 @@ static void gem_realize(DeviceState *dev, Error **errp)
         sysbus_init_irq(SYS_BUS_DEVICE(dev), &s->irq[i]);
     }
 
+    gem_init_register_masks(s);
     qemu_macaddr_default_if_unset(&s->conf.macaddr);
 
     s->nic = qemu_new_nic(&net_gem_info, &s->conf,
@@ -1776,7 +1777,6 @@ static void gem_init(Object *obj)
 
     DB_PRINT("\n");
 
-    gem_init_register_masks(s);
     memory_region_init_io(&s->iomem, OBJECT(s), &gem_ops, s,
                           "enet", sizeof(s->regs));