]> git.ipfire.org Git - thirdparty/starlette.git/commitdiff
Remove note about `BackgroundTasks` being a limitation on the `BaseHTTPMiddleware...
authorMarcelo Trylesinski <marcelotryle@gmail.com>
Wed, 28 Sep 2022 06:14:05 +0000 (08:14 +0200)
committerGitHub <noreply@github.com>
Wed, 28 Sep 2022 06:14:05 +0000 (08:14 +0200)
Co-authored-by: Adrian Garcia Badaracco <1755071+adriangb@users.noreply.github.com>
docs/middleware.md

index bf54c2109c5c0467ad427a303d57e39a8f39b6b3..e84c361a7c4cfef8360c2697df3f17a747083072 100644 (file)
@@ -243,7 +243,6 @@ around explicitly, rather than mutating the middleware instance.
 
 Currently, the `BaseHTTPMiddleware` has some known limitations:
 
-- It's not possible to use `BackgroundTasks` with `BaseHTTPMiddleware`. Check [#1438](https://github.com/encode/starlette/issues/1438) for more details.
 - Using `BaseHTTPMiddleware` will prevent changes to [`contextlib.ContextVar`](https://docs.python.org/3/library/contextvars.html#contextvars.ContextVar)s from propagating upwards. That is, if you set a value for a `ContextVar` in your endpoint and try to read it from a middleware you will find that the value is not the same value you set in your endpoint (see [this test](https://github.com/encode/starlette/blob/621abc747a6604825190b93467918a0ec6456a24/tests/middleware/test_base.py#L192-L223) for an example of this behavior).
 
 To overcome these limitations, use [pure ASGI middleware](#pure-asgi-middleware), as shown below.