]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
firmware: exynos-acpm: Correct kerneldoc and use typical np argument name
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 24 Apr 2025 20:33:09 +0000 (22:33 +0200)
committerKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Fri, 25 Apr 2025 09:41:03 +0000 (11:41 +0200)
Correct kerneldoc warnings after commit a8dc26a0ec43 ("firmware:
exynos-acpm: introduce devm_acpm_get_by_node()") changed the function
prototype:

  exynos-acpm.c:672: warning: Function parameter or struct member 'acpm_np' not described in 'acpm_get_by_node'
  exynos-acpm.c:672: warning: expecting prototype for acpm_get_by_phandle(). Prototype was for acpm_get_by_node() instead

While touching the lines, change the name of device_node pointer to
'np' to match convention.

Fixes: a8dc26a0ec43 ("firmware: exynos-acpm: introduce devm_acpm_get_by_node()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202504222051.7TqaSQ48-lkp@intel.com/
Reviewed-by: Tudor Ambarus <tudor.ambarus@linaro.org>
Link: https://lore.kernel.org/r/20250424203308.402168-2-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
drivers/firmware/samsung/exynos-acpm.c

index 93f87cd90f24938a469dbcf014034ae3e9176df4..5266b66a32e12255293d2d4e68b57d74aea98e55 100644 (file)
@@ -661,20 +661,20 @@ static void devm_acpm_release(struct device *dev, void *res)
 }
 
 /**
- * acpm_get_by_phandle() - get the ACPM handle using DT phandle.
- * @dev:        device pointer requesting ACPM handle.
- * @property:   property name containing phandle on ACPM node.
+ * acpm_get_by_node() - get the ACPM handle using node pointer.
+ * @dev:       device pointer requesting ACPM handle.
+ * @np:                ACPM device tree node.
  *
  * Return: pointer to handle on success, ERR_PTR(-errno) otherwise.
  */
 static const struct acpm_handle *acpm_get_by_node(struct device *dev,
-                                                 struct device_node *acpm_np)
+                                                 struct device_node *np)
 {
        struct platform_device *pdev;
        struct device_link *link;
        struct acpm_info *acpm;
 
-       pdev = of_find_device_by_node(acpm_np);
+       pdev = of_find_device_by_node(np);
        if (!pdev)
                return ERR_PTR(-EPROBE_DEFER);