Remove CloseHandle() from __archive_write_program_free

The call to CloseHandle() is asymmetric and wrong.

The handle is created during the __achive_create_child() call in
__archive_write_program_open() aka the filter open callback.

While CloseHandle() is already called in the filter close callback aka
__archive_write_program_close().

Remove the incorrect call to CloseHandle() from the bidder free callback

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

diff --git a/libarchive/archive_write_add_filter_program.c b/libarchive/archive_write_add_filter_program.c
index 3dac86dc3bded94b2fccc605d75f2b56b3b271e8..c096e7227ba4355123ae47096bf6a688daf2a199 100644 (file)
--- a/libarchive/archive_write_add_filter_program.c
+++ b/libarchive/archive_write_add_filter_program.c
@@ -196,10 +196,6 @@ __archive_write_program_free(struct archive_write_program_data *data)
 {
 
        if (data) {
-#if defined(_WIN32) && !defined(__CYGWIN__)
-               if (data->child)
-                       CloseHandle(data->child);
-#endif
                free(data->program_name);
                free(data->child_buf);
                free(data);