Optimization: clientStreamInit() copied ClientStreamData (#1801)

Detected by Coverity. CID 1529543 and CID 1529594: Unnecessary object
copies can affect performance (COPY_INSTEAD_OF_MOVE).

diff --git a/src/clientStream.cc b/src/clientStream.cc
index ecc316aacf59c5c56baf0e0c9416aecf6c3e52eb..cb28bdcfcd6032ba46e13f0067ad04a3cd06be6d 100644 (file)
--- a/src/clientStream.cc
+++ b/src/clientStream.cc
@@ -110,7 +110,7 @@ clientStreamNode::~clientStreamNode()
  */
 void
 clientStreamInit(dlink_list * list, CSR * func, CSD * rdetach, CSS * readstatus,
-                 ClientStreamData readdata, CSCB * callback, CSD * cdetach, ClientStreamData callbackdata,
+                 const ClientStreamData &readdata, CSCB * callback, CSD * cdetach, const ClientStreamData &callbackdata,
                  StoreIOBuffer tailBuffer)
 {
     clientStreamNode *temp = new clientStreamNode(func, nullptr, rdetach, readstatus, readdata);

diff --git a/src/clientStream.h b/src/clientStream.h
index 49a10683850cb2a08da15b2f2a97bb5341a9b5e8..a64ffcf1b7699a2b8ad38f492b6acab72b9678f7 100644 (file)
--- a/src/clientStream.h
+++ b/src/clientStream.h
@@ -95,7 +95,7 @@ public:
 };
 
 /// \ingroup ClientStreamAPI
-void clientStreamInit(dlink_list *, CSR *, CSD *, CSS *, ClientStreamData, CSCB *, CSD *, ClientStreamData, StoreIOBuffer tailBuffer);
+void clientStreamInit(dlink_list *, CSR *, CSD *, CSS *, const ClientStreamData &, CSCB *, CSD *, const ClientStreamData &, StoreIOBuffer tailBuffer);
 
 /// \ingroup ClientStreamAPI
 void clientStreamInsertHead(dlink_list *, CSR *, CSCB *, CSD *, CSS *, ClientStreamData);