]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mfd: as3722: Fix wakeup source leaks on device unbind
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 6 Apr 2025 19:50:10 +0000 (21:50 +0200)
committerLee Jones <lee@kernel.org>
Fri, 23 May 2025 07:49:07 +0000 (08:49 +0100)
Device can be unbound, so driver must also release memory for the wakeup
source.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20250406-mfd-device-wakekup-leak-v1-2-318e14bdba0a@linaro.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/mfd/as3722.c

index 6c0d89b0c7e3faa2f82a265df245c6abc6617e48..7ab6fcc9c27c8f8284d5e2a7bf4291d582b9ca22 100644 (file)
@@ -394,7 +394,9 @@ static int as3722_i2c_probe(struct i2c_client *i2c)
                return ret;
        }
 
-       device_init_wakeup(as3722->dev, true);
+       ret = devm_device_init_wakeup(as3722->dev);
+       if (ret)
+               return dev_err_probe(as3722->dev, ret, "Failed to init wakeup\n");
 
        dev_dbg(as3722->dev, "AS3722 core driver initialized successfully\n");
        return 0;