]> git.ipfire.org Git - thirdparty/xfsprogs-dev.git/commitdiff
xfs: Fix default ASSERT in xfs_attr_set_iter
authorAllison Henderson <allison.henderson@oracle.com>
Fri, 15 Oct 2021 20:28:27 +0000 (16:28 -0400)
committerEric Sandeen <sandeen@sandeen.net>
Fri, 15 Oct 2021 20:28:27 +0000 (16:28 -0400)
Source kernel commit: 4a4957c16dc674d1306a3b43d6b07ed93a7b7a14

This ASSERT checks for the state value of RM_SHRINK in the set path
which should never happen.  Change to ASSERT(0);

Suggested-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
libxfs/xfs_attr.c

index edc19de6b809793812a8610f9fea8fe4f2ea3635..cbac7612644bea4b76140f0f17aede36746c2b07 100644 (file)
@@ -612,7 +612,7 @@ xfs_attr_set_iter(
                error = xfs_attr_node_addname_clear_incomplete(dac);
                break;
        default:
-               ASSERT(dac->dela_state != XFS_DAS_RM_SHRINK);
+               ASSERT(0);
                break;
        }
 out: