]> git.ipfire.org Git - thirdparty/binutils-gdb.git/commitdiff
small coffgen.c tidy
authorAlan Modra <amodra@gmail.com>
Fri, 13 Dec 2024 03:18:45 +0000 (13:48 +1030)
committerAlan Modra <amodra@gmail.com>
Fri, 13 Dec 2024 03:26:15 +0000 (13:56 +1030)
_bfd_coff_free_cached_info should always call
_bfd_generic_bfd_free_cached_info, even if _bfd_coff_free_symbols
returns an error.  (It won't return an error here, but let's not leave
anyone wondering about _bfd_coff_free_cached_info.)

* coffgen.c (_bfd_coff_free_cached_info): Ignore return status
of _bfd_coff_free_symbols.

bfd/coffgen.c

index dc5b0f4002030d6a43903a82b4f120f80fc43548..27bd54dcdd0a64aa5e4a030e66782f476c905878 100644 (file)
@@ -3295,8 +3295,7 @@ _bfd_coff_free_cached_info (bfd *abfd)
         Do not clear the keep_syms and keep_strings flags.
         These may have been set by pe_ILF_build_a_bfd() indicating
         that the syms and strings pointers are not to be freed.  */
-      if (!_bfd_coff_free_symbols (abfd))
-       return false;
+      _bfd_coff_free_symbols (abfd);
     }
 
   return _bfd_generic_bfd_free_cached_info (abfd);