]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
scsi: logging: Fix scsi_logging_level bounds
authorNicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Mon, 24 Feb 2025 09:58:19 +0000 (10:58 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 4 Mar 2025 03:11:48 +0000 (22:11 -0500)
Bound scsi_logging_level sysctl writings between SYSCTL_ZERO and
SYSCTL_INT_MAX.

The proc_handler has thus been updated to proc_dointvec_minmax.

Signed-off-by: Nicolas Bouchinet <nicolas.bouchinet@ssi.gouv.fr>
Link: https://lore.kernel.org/r/20250224095826.16458-5-nicolas.bouchinet@clip-os.org
Reviewed-by: Joel Granados <joel.granados@kernel.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/scsi_sysctl.c

index be4aef0f4f9962c32c4bfed020e62d0ad1e86b65..055a03a83ad68ec4ac5f171e79a1e98658b7e78d 100644 (file)
@@ -17,7 +17,9 @@ static const struct ctl_table scsi_table[] = {
          .data         = &scsi_logging_level,
          .maxlen       = sizeof(scsi_logging_level),
          .mode         = 0644,
-         .proc_handler = proc_dointvec },
+         .proc_handler = proc_dointvec_minmax,
+         .extra1       = SYSCTL_ZERO,
+         .extra2       = SYSCTL_INT_MAX },
 };
 
 static struct ctl_table_header *scsi_table_header;