]> git.ipfire.org Git - thirdparty/plymouth.git/commitdiff
[main] watch keyboard input after displays are added
authorRay Strode <rstrode@redhat.com>
Mon, 29 Mar 2010 19:20:44 +0000 (15:20 -0400)
committerRay Strode <rstrode@redhat.com>
Mon, 29 Mar 2010 19:20:44 +0000 (15:20 -0400)
Since the boot splashes handle opening the terminal now,
we need to make sure that we don't try to watch for input on
the terminal until they've opened it.

This should fix some crashes users are reportedly seeing with
the details splash.

A potentially better fix would be to make watch_for_input defer
doing anything on its own using the terminal is opened.  That
would require a trigger and some new api to ply-terminal, I think.

src/main.c

index d3d670dd55da06b68172c114cea3299c1bc98e67..0646ad8c31a9c3c49e4e2a5e5bda92e22ba8cda3 100644 (file)
@@ -1220,7 +1220,6 @@ set_keyboard (state_t        *state,
   ply_keyboard_add_enter_handler (keyboard,
                                   (ply_keyboard_enter_handler_t)
                                   on_enter, state);
-  ply_keyboard_watch_for_input (keyboard);
 }
 static void
 add_display_and_keyboard_for_terminal (state_t    *state,
@@ -1347,6 +1346,8 @@ add_displays_and_keyboard_to_boot_splash (state_t           *state,
 
       node = next_node;
     }
+
+  ply_keyboard_watch_for_input (state->keyboard);
 }
 
 static ply_boot_splash_t *