]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ext4: use ext4_update_inode_fsync_trans() helper in inode creation
authorLuis Henriques (SUSE) <luis.henriques@linux.dev>
Mon, 27 May 2024 16:14:47 +0000 (17:14 +0100)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 5 Jul 2024 20:48:54 +0000 (16:48 -0400)
Call helper function ext4_update_inode_fsync_trans() instead of open
coding it in __ext4_new_inode().  This helper checks both that the handle
is valid *and* that it hasn't been aborted due to some fatal error in the
journalling layer, using is_handle_aborted().

Signed-off-by: Luis Henriques (SUSE) <luis.henriques@linux.dev>
Link: https://patch.msgid.link/20240527161447.21434-1-luis.henriques@linux.dev
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ialloc.c

index e9bbb1da2d0a24d29b0f3f875e4aa96d5cf9d833..9dfd768ed9f8d9044b55fe8b9fe888e3cd6794b9 100644 (file)
@@ -1336,10 +1336,7 @@ got:
                }
        }
 
-       if (ext4_handle_valid(handle)) {
-               ei->i_sync_tid = handle->h_transaction->t_tid;
-               ei->i_datasync_tid = handle->h_transaction->t_tid;
-       }
+       ext4_update_inode_fsync_trans(handle, inode, 1);
 
        err = ext4_mark_inode_dirty(handle, inode);
        if (err) {