]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: iwlwifi: mld: remove one more error in unallocated BAID
authorMiri Korenblit <miriam.rachel.korenblit@intel.com>
Tue, 6 May 2025 19:40:48 +0000 (22:40 +0300)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Fri, 9 May 2025 12:35:46 +0000 (15:35 +0300)
Since the FW is the one to assign an ID to a BA, it can happen that
the FW sends a bar_frame_release_notif before the driver had the chance to
allocate the BAID.

Convert the IWL_FW_CHECK into a regular debug print.

Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Link: https://patch.msgid.link/20250506194102.3407967-2-miriam.rachel.korenblit@intel.com
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
drivers/net/wireless/intel/iwlwifi/mld/agg.c

index 393cc0e27052595d1b445a3d569b2eb7057ccf1f..bda488ae9eec24567a3a53ac17925b7c7b16edf7 100644 (file)
@@ -124,10 +124,12 @@ void iwl_mld_handle_bar_frame_release_notif(struct iwl_mld *mld,
 
        rcu_read_lock();
        baid_data = rcu_dereference(mld->fw_id_to_ba[baid]);
-       if (!IWL_FW_CHECK(mld, !baid_data,
-                         "Got valid BAID %d but not allocated, invalid BAR release!\n",
-                         baid))
+       if (!baid_data) {
+               IWL_DEBUG_HT(mld,
+                            "Got valid BAID %d but not allocated\n",
+                            baid);
                goto out_unlock;
+       }
 
        if (IWL_FW_CHECK(mld, tid != baid_data->tid ||
                         sta_id > mld->fw->ucode_capa.num_stations ||