drm/bridge: dw-hdmi-qp: replace mode_valid with tmds_char_rate

Replace .mode_valid() callback with .hdmi_tmds_char_rate_valid(). It is
more generic and is used in other mode validation paths. The rate
validation for .mode_valid() will be performed by the
drm_bridge_connector code.

Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20241130-hdmi-mode-valid-v5-9-742644ec3b1f@linaro.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
index 181c5164b23192f0b557624d73c6223032b90ec6..c686671e4850a1af75b82995185ffc3cbb22a447 100644 (file)
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-qp.c
@@ -442,16 +442,14 @@ dw_hdmi_qp_bridge_edid_read(struct drm_bridge *bridge,
 }
 
 static enum drm_mode_status
-dw_hdmi_qp_bridge_mode_valid(struct drm_bridge *bridge,
-                            const struct drm_display_info *info,
-                            const struct drm_display_mode *mode)
+dw_hdmi_qp_bridge_tmds_char_rate_valid(const struct drm_bridge *bridge,
+                                      const struct drm_display_mode *mode,
+                                      unsigned long long rate)
 {
        struct dw_hdmi_qp *hdmi = bridge->driver_private;
-       unsigned long long rate;
 
-       rate = drm_hdmi_compute_mode_clock(mode, 8, HDMI_COLORSPACE_RGB);
        if (rate > HDMI14_MAX_TMDSCLK) {
-               dev_dbg(hdmi->dev, "Unsupported mode clock: %d\n", mode->clock);
+               dev_dbg(hdmi->dev, "Unsupported TMDS char rate: %lld\n", rate);
                return MODE_CLOCK_HIGH;
        }
 
@@ -510,7 +508,7 @@ static const struct drm_bridge_funcs dw_hdmi_qp_bridge_funcs = {
        .atomic_disable = dw_hdmi_qp_bridge_atomic_disable,
        .detect = dw_hdmi_qp_bridge_detect,
        .edid_read = dw_hdmi_qp_bridge_edid_read,
-       .mode_valid = dw_hdmi_qp_bridge_mode_valid,
+       .hdmi_tmds_char_rate_valid = dw_hdmi_qp_bridge_tmds_char_rate_valid,
        .hdmi_clear_infoframe = dw_hdmi_qp_bridge_clear_infoframe,
        .hdmi_write_infoframe = dw_hdmi_qp_bridge_write_infoframe,
 };