]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
veristat: Strerror expects positive number (errno)
authorEduard Zingerman <eddyz87@gmail.com>
Sat, 1 Mar 2025 00:01:46 +0000 (16:01 -0800)
committerAlexei Starovoitov <ast@kernel.org>
Sat, 15 Mar 2025 18:48:26 +0000 (11:48 -0700)
Before:

  ./veristat -G @foobar iters.bpf.o
  Failed to open presets in 'foobar': Unknown error -2
  ...

After:

  ./veristat -G @foobar iters.bpf.o
  Failed to open presets in 'foobar': No such file or directory
  ...

Signed-off-by: Eduard Zingerman <eddyz87@gmail.com>
Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Acked-by: Mykyta Yatsenko <mykyta.yatsenko5@gmail.com>
Link: https://lore.kernel.org/bpf/20250301000147.1583999-3-eddyz87@gmail.com
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
tools/testing/selftests/bpf/veristat.c

index 8bc462299290250d23914aa22b7f08bbd47e0e16..41dfcb6f569037e67d85e573dc203cb151a5dced 100644 (file)
@@ -660,7 +660,7 @@ static int append_filter_file(const char *path)
        f = fopen(path, "r");
        if (!f) {
                err = -errno;
-               fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(err));
+               fprintf(stderr, "Failed to open filters in '%s': %s\n", path, strerror(-err));
                return err;
        }
 
@@ -1422,7 +1422,7 @@ static int append_var_preset_file(const char *filename)
        f = fopen(filename, "rt");
        if (!f) {
                err = -errno;
-               fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(err));
+               fprintf(stderr, "Failed to open presets in '%s': %s\n", filename, strerror(-err));
                return -EINVAL;
        }