]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
pinctrl: stm32: Use scope based of_node_put() cleanups
authorPeng Fan <peng.fan@nxp.com>
Sat, 4 May 2024 13:20:01 +0000 (21:20 +0800)
committerLinus Walleij <linus.walleij@linaro.org>
Mon, 17 Jun 2024 07:21:32 +0000 (09:21 +0200)
Use scope based of_node_put() cleanup to simplify code.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Link: https://lore.kernel.org/r/20240504-pinctrl-cleanup-v2-3-26c5f2dc1181@nxp.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/stm32/pinctrl-stm32.c

index 978ccdbaf3d3f400a61eca4f888e211cb76add66..a8673739871d811c736312a2b6d841cede7738f7 100644 (file)
@@ -670,7 +670,6 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
                                 struct device_node *np_config,
                                 struct pinctrl_map **map, unsigned *num_maps)
 {
-       struct device_node *np;
        unsigned reserved_maps;
        int ret;
 
@@ -678,12 +677,11 @@ static int stm32_pctrl_dt_node_to_map(struct pinctrl_dev *pctldev,
        *num_maps = 0;
        reserved_maps = 0;
 
-       for_each_child_of_node(np_config, np) {
+       for_each_child_of_node_scoped(np_config, np) {
                ret = stm32_pctrl_dt_subnode_to_map(pctldev, np, map,
                                &reserved_maps, num_maps);
                if (ret < 0) {
                        pinctrl_utils_free_map(pctldev, *map, *num_maps);
-                       of_node_put(np);
                        return ret;
                }
        }