]> git.ipfire.org Git - thirdparty/dovecot/core.git/commitdiff
lib: net - Use result from getaddrinfo() without copying
authorAki Tuomi <aki.tuomi@open-xchange.com>
Wed, 20 Apr 2022 09:31:31 +0000 (12:31 +0300)
committertimo.sirainen <timo.sirainen@open-xchange.com>
Mon, 25 Apr 2022 11:25:00 +0000 (11:25 +0000)
Fixes scan-build complaint.

Broken in dd7aacc76da40b24451b40b7c0429807d0345be8

src/lib/net.c

index ce101e85074ab93c460af183326ecceefedd77da..ad3803457d897154833e50fe6956ccabfe3fd39d 100644 (file)
@@ -1001,9 +1001,9 @@ int net_addr2ip(const char *addr, struct ip_addr *ip)
                };
                if ((ret = getaddrinfo(addr, NULL, &hints, &res)) == 0) {
                        i_assert(res != NULL);
-                       union sockaddr_union u;
-                       memcpy(&u.sa, res->ai_addr, res->ai_addrlen);
-                       sin_get_ip(&u, ip);
+                       const union sockaddr_union *so =
+                               (union sockaddr_union *)res->ai_addr;
+                       sin_get_ip(so, ip);
                }
                if (res != NULL)
                        freeaddrinfo(res);