btrfs: replace deprecated strncpy() with strscpy()

strncpy() is deprecated for NUL-terminated destination buffers. Use
strscpy() instead and don't zero-initialize the param array.

Link: https://github.com/KSPP/linux/issues/90
Cc: linux-hardening@vger.kernel.org
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/sysfs.c b/fs/btrfs/sysfs.c
index 53b846d99ecea8dbd7b87378c6c495927e62c8e9..14f53f757555388483025673d86539436ecfb22b 100644 (file)
--- a/fs/btrfs/sysfs.c
+++ b/fs/btrfs/sysfs.c
@@ -1330,13 +1330,13 @@ MODULE_PARM_DESC(read_policy,
 
 int btrfs_read_policy_to_enum(const char *str, s64 *value_ret)
 {
-       char param[32] = { 0 };
+       char param[32];
        char __maybe_unused *value_str;
 
        if (!str || strlen(str) == 0)
                return 0;
 
-       strncpy(param, str, sizeof(param) - 1);
+       strscpy(param, str);
 
 #ifdef CONFIG_BTRFS_EXPERIMENTAL
        /* Separate value from input in policy:value format. */