gdb, testsuite: Fix argument unused warning with clang

Since clang 19 we see:
~~
clang: warning: argument unused during compilation: '-nostartfiles' [-Wunused-command-line-argument]^M
gdb compile failed, clang: warning: argument unused during compilation: '-nostartfiles' [-Wunused-command-line-argument]
UNTESTED: gdb.arch/amd64-init-x87-values.exp: failed to prepare
~~

Fix this by only passing '-nostartfiles' when linking.

Approved-By: Tom Tromey <tom@tromey.com>

diff --git a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
index 871972c0426872ec4374194123064ed992a9fbf4..5bbadaf2f5be6a2178c9f23913110ab26307a435 100644 (file)
--- a/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
+++ b/gdb/testsuite/gdb.arch/amd64-init-x87-values.exp
@@ -24,7 +24,7 @@ standard_testfile .S
 
 set options [list debug \
                 additional_flags=-static \
-                additional_flags=-nostartfiles]
+                ldflags=-nostartfiles]
 if { [build_executable "failed to prepare" ${testfile} ${srcfile} $options] } {
     return -1
 }

diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp b/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp
index 6fdb1b2ee68477ee79f99379927218d578e721ad..016478f0080ec841b2d2ee7a3840cd4c4522b365 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp
+++ b/gdb/testsuite/gdb.dwarf2/debug-names-bad-cu-index.exp
@@ -21,7 +21,7 @@ require dwarf2_support
 standard_testfile _start.c debug-names.S
 
 set func_info_vars \
-    [get_func_info _start [list debug additional_flags=-nostartfiles]]
+    [get_func_info _start [list debug ldflags=-nostartfiles]]
 
 # Create the DWARF.
 set asm_file [standard_output_file $srcfile2]
@@ -76,7 +76,7 @@ Dwarf::assemble {
 }
 
 if {[build_executable ${testfile}.exp $testfile "${asm_file} ${srcfile}" \
-        [list additional_flags=-nostartfiles]] == -1} {
+        [list ldflags=-nostartfiles]] == -1} {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp
index 5c84480e1570e594412be12ba951ac76531d889f..28f215711847ccccc67e8e49c738ed6546eb2ff6 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp
+++ b/gdb/testsuite/gdb.dwarf2/debug-names-duplicate-cu.exp
@@ -21,7 +21,7 @@ require dwarf2_support
 standard_testfile _start.c debug-names.S
 
 set func_info_vars \
-    [get_func_info _start [list debug additional_flags=-nostartfiles]]
+    [get_func_info _start [list debug ldflags=-nostartfiles]]
 
 # Create the DWARF.
 set asm_file [standard_output_file $srcfile2]
@@ -60,7 +60,7 @@ Dwarf::assemble {
 }
 
 if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \
-       [list additional_flags=-nostartfiles]] {
+       [list ldflags=-nostartfiles]] {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp b/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp
index 64550abb06f4059a346faa0ad25c9677a4e7d2b5..77db144275832db040928904241ea01ddf7be6ae 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp
+++ b/gdb/testsuite/gdb.dwarf2/debug-names-missing-cu.exp
@@ -25,7 +25,7 @@ require !readnow
 standard_testfile _start.c debug-names.S
 
 set func_info_vars \
-    [get_func_info _start [list debug additional_flags=-nostartfiles]]
+    [get_func_info _start [list debug ldflags=-nostartfiles]]
 
 # Create the DWARF.
 set asm_file [standard_output_file $srcfile2]
@@ -67,7 +67,7 @@ Dwarf::assemble {
 }
 
 if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \
-       [list additional_flags=-nostartfiles]] {
+       [list ldflags=-nostartfiles]] {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl b/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl
index 6ab6142f8a1569586133a512ec8b99d697fa392a..4de96ffe20e8833bd1780d50cb79b9bdd09c8fde 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl
+++ b/gdb/testsuite/gdb.dwarf2/debug-names-tu.exp.tcl
@@ -25,7 +25,7 @@ require !readnow
 standard_testfile _start.c debug-names.S
 
 set func_info_vars \
-    [get_func_info _start [list debug additional_flags=-nostartfiles]]
+    [get_func_info _start [list debug ldflags=-nostartfiles]]
 
 # Create the DWARF.
 set asm_file [standard_output_file $srcfile2]
@@ -84,7 +84,7 @@ Dwarf::assemble {
 }
 
 if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \
-       [list additional_flags=-nostartfiles]] {
+       [list ldflags=-nostartfiles]] {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.dwarf2/debug-names.exp b/gdb/testsuite/gdb.dwarf2/debug-names.exp
index 5ef21a6725548a7837a76c1a7973f458a88a8e3e..7f63af29b4343d11dd125620dadacf83a1d1156f 100644 (file)
--- a/gdb/testsuite/gdb.dwarf2/debug-names.exp
+++ b/gdb/testsuite/gdb.dwarf2/debug-names.exp
@@ -21,7 +21,7 @@ require dwarf2_support
 standard_testfile _start.c debug-names.S
 
 set func_info_vars \
-    [get_func_info _start [list debug additional_flags=-nostartfiles]]
+    [get_func_info _start [list debug ldflags=-nostartfiles]]
 
 # Create the DWARF.
 set asm_file [standard_output_file $srcfile2]
@@ -59,7 +59,7 @@ Dwarf::assemble {
 }
 
 if [prepare_for_testing "failed to prepare" $testfile "${asm_file} ${srcfile}" \
-       [list additional_flags=-nostartfiles]] {
+       [list ldflags=-nostartfiles]] {
     return -1
 }
 

diff --git a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
index 47482a2e35ff2e2b5c24511f779164373da49d2d..23adbb03bb54d32fd8317ba81185b880f71e7102 100644 (file)
--- a/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
+++ b/gdb/testsuite/gdb.tui/tui-layout-asm-short-prog.exp
@@ -24,7 +24,7 @@ set opts {}
 lappend opts debug
 lappend opts additional_flags=-static
 lappend opts additional_flags=-nostdlib
-lappend opts additional_flags=-nostartfiles
+lappend opts ldflags=-nostartfiles
 
 if { [build_executable "failed to prepare" $testfile $srcfile $opts] == -1 } {
     return -1