]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
smb/server: add comment to FileSystemName of FileFsAttributeInformation
authorChenXiaoSong <chenxiaosong@kylinos.cn>
Tue, 18 Nov 2025 03:00:40 +0000 (11:00 +0800)
committerSteve French <stfrench@microsoft.com>
Wed, 10 Dec 2025 03:01:36 +0000 (21:01 -0600)
Explained why FileSystemName is always set to "NTFS".

Link: https://github.com/namjaejeon/ksmbd/commit/84392651b0b740d2f59bcacd3b4cfff8ae0051a0
Signed-off-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/server/smb2pdu.c

index f3184b2175757757139bbc2daa5b925cfaf9de46..27f87a13f20a7533d29801b48d9f2f119a4ea182 100644 (file)
@@ -5497,6 +5497,13 @@ static int smb2_get_info_filesystem(struct ksmbd_work *work,
                        info->Attributes |= cpu_to_le32(FILE_NAMED_STREAMS);
 
                info->MaxPathNameComponentLength = cpu_to_le32(stfs.f_namelen);
+               /*
+                * some application(potableapp) can not run on ksmbd share
+                * because only NTFS handle security setting on windows.
+                * So Although local fs(EXT4 or F2fs, etc) is not NTFS,
+                * ksmbd should show share as NTFS. Later, If needed, we can add
+                * fs type(s) parameter to change fs type user wanted.
+                */
                len = smbConvertToUTF16((__le16 *)info->FileSystemName,
                                        "NTFS", PATH_MAX, conn->local_nls, 0);
                len = len * 2;