ntlm_auth: Fix Coverity ID 240747 Resource leak

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Ralph Boehme <slow@samba.org>

diff --git a/source3/utils/ntlm_auth_diagnostics.c b/source3/utils/ntlm_auth_diagnostics.c
index 69034434148a120b7b232d8af18ccdd2892c15bc..b0c5f490f7f09e0bca6d2564e5cb23a0c5bc8d91 100644 (file)
--- a/source3/utils/ntlm_auth_diagnostics.c
+++ b/source3/utils/ntlm_auth_diagnostics.c
@@ -375,7 +375,7 @@ static bool test_lmv2_ntlmv2_broken(enum ntlm_break break_which)
        uint8_t authoritative = 1;
        uchar user_session_key[16];
        DATA_BLOB chall = get_challenge();
-       char *error_string;
+       char *error_string = NULL;
 
        ZERO_STRUCT(user_session_key);
 
@@ -429,6 +429,8 @@ static bool test_lmv2_ntlmv2_broken(enum ntlm_break break_which)
                return break_which == BREAK_NT;
        }
 
+       SAFE_FREE(error_string);
+
        if (break_which != NO_NT && break_which != BREAK_NT && memcmp(ntlmv2_session_key.data, user_session_key,
                   sizeof(user_session_key)) != 0) {
                DEBUG(1, ("USER (NTLMv2) Session Key does not match expectations!\n"));