]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
bcachefs: darray: Don't pass NULL to memcpy()
authorTavian Barnes <tavianator@tavianator.com>
Fri, 21 Jun 2024 20:29:32 +0000 (16:29 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Mon, 15 Jul 2024 01:52:37 +0000 (21:52 -0400)
memcpy's second parameter must not be NULL, even if size is zero.

Signed-off-by: Tavian Barnes <tavianator@tavianator.com>
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/darray.c

index ac35b8b705ae1c076e780af570bd824d87c28ab2..b7d223f85873e2e8e5c2d1b0969f28dc5c06d1ff 100644 (file)
@@ -13,7 +13,8 @@ int __bch2_darray_resize(darray_char *d, size_t element_size, size_t new_size, g
                if (!data)
                        return -ENOMEM;
 
-               memcpy(data, d->data, d->size * element_size);
+               if (d->size)
+                       memcpy(data, d->data, d->size * element_size);
                if (d->data != d->preallocated)
                        kvfree(d->data);
                d->data = data;