]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: et8ek8: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:33:55 +0000 (15:33 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:19 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/et8ek8/et8ek8_driver.c

index 7519863d77b1c49174861f8842ba05af9144466b..4787b2c430f8e0da4e475391d1f6cf4f504c8302 100644 (file)
@@ -1433,11 +1433,10 @@ static int et8ek8_probe(struct i2c_client *client)
                return PTR_ERR(sensor->vana);
        }
 
-       sensor->ext_clk = devm_clk_get(dev, NULL);
-       if (IS_ERR(sensor->ext_clk)) {
-               dev_err(&client->dev, "could not get clock\n");
-               return PTR_ERR(sensor->ext_clk);
-       }
+       sensor->ext_clk = devm_v4l2_sensor_clk_get(dev, NULL);
+       if (IS_ERR(sensor->ext_clk))
+               return dev_err_probe(&client->dev, PTR_ERR(sensor->ext_clk),
+                                    "could not get clock\n");
 
        ret = of_property_read_u32(dev->of_node, "clock-frequency",
                                   &sensor->xclk_freq);