]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
serial: sc16is7xx: replace hardcoded divisor value with BIT() macro
authorHugo Villeneuve <hvilleneuve@dimonoff.com>
Thu, 21 Dec 2023 23:18:19 +0000 (18:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 4 Jan 2024 15:30:04 +0000 (16:30 +0100)
To better show why the limit is what it is, since we have only 16 bits for
the divisor.

Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Link: https://lore.kernel.org/r/20231221231823.2327894-13-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/sc16is7xx.c

index da862b8efcbef1d1e46335597d67c28768c53754..3d963fe0e78a027bbc6a91bfe8bea9aeeb5d35cf 100644 (file)
@@ -486,7 +486,7 @@ static int sc16is7xx_set_baud(struct uart_port *port, int baud)
        u8 prescaler = 0;
        unsigned long clk = port->uartclk, div = clk / 16 / baud;
 
-       if (div > 0xffff) {
+       if (div >= BIT(16)) {
                prescaler = SC16IS7XX_MCR_CLKSEL_BIT;
                div /= 4;
        }