]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Revert "arm64: dts: qcom: x1e80100-crd: enable otg on usb ports"
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 10 Dec 2024 11:14:43 +0000 (12:14 +0100)
committerBjorn Andersson <andersson@kernel.org>
Thu, 19 Dec 2024 18:44:30 +0000 (12:44 -0600)
This reverts commit 2dd3250191bcfe93b0c9da46624af830310400a7.

A recent change enabling OTG mode on the x1e81000 CRD breaks suspend.
Specifically, the device hard resets during resume if suspended with all
controllers in device mode (i.e. no USB device connected).

The corresponding change on the T14s also led to SuperSpeed hotplugs not
being detected.

With retimer (and orientation detection) support not even merged yet,
let's revert at least until we have stable host mode in mainline.

Fixes: 2dd3250191bc ("arm64: dts: qcom: x1e80100-crd: enable otg on usb ports")
Reported-by: Abel Vesa <abel.vesa@linaro.org>
Cc: Jonathan Marek <jonathan@marek.ca>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Link: https://lore.kernel.org/r/20241210111444.26240-3-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100-crd.dts

index 39f9d9cdc10d8e79824b72288e2529536144fa9e..d51a9bdcf67fcbe2e59bd742637ee21de17f0eea 100644 (file)
        status = "okay";
 };
 
+&usb_1_ss0_dwc3 {
+       dr_mode = "host";
+};
+
 &usb_1_ss0_dwc3_hs {
        remote-endpoint = <&pmic_glink_ss0_hs_in>;
 };
        status = "okay";
 };
 
+&usb_1_ss1_dwc3 {
+       dr_mode = "host";
+};
+
 &usb_1_ss1_dwc3_hs {
        remote-endpoint = <&pmic_glink_ss1_hs_in>;
 };
        status = "okay";
 };
 
+&usb_1_ss2_dwc3 {
+       dr_mode = "host";
+};
+
 &usb_1_ss2_dwc3_hs {
        remote-endpoint = <&pmic_glink_ss2_hs_in>;
 };