]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: dwc3: Ignore late xferNotReady event to prevent halt timeout
authorKuen-Han Tsai <khtsai@google.com>
Thu, 7 Aug 2025 09:06:55 +0000 (17:06 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Aug 2025 14:34:41 +0000 (16:34 +0200)
commit 58577118cc7cec9eb7c1836bf88f865ff2c5e3a3 upstream.

During a device-initiated disconnect, the End Transfer command resets
the event filter, allowing a new xferNotReady event to be generated
before the controller is fully halted. Processing this late event
incorrectly triggers a Start Transfer, which prevents the controller
from halting and results in a DSTS.DEVCTLHLT bit polling timeout.

Ignore the late xferNotReady event if the controller is already in a
disconnected state.

Fixes: 72246da40f37 ("usb: Introduce DesignWare USB3 DRD Driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Kuen-Han Tsai <khtsai@google.com>
Acked-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Link: https://lore.kernel.org/r/20250807090700.2397190-1-khtsai@google.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc3/gadget.c

index 74968f93d4a3538ef77e64270c45365b21366a2c..dff03f0826ab810d9008d671aadee34516f9addd 100644 (file)
@@ -3779,6 +3779,15 @@ static void dwc3_gadget_endpoint_transfer_complete(struct dwc3_ep *dep,
 static void dwc3_gadget_endpoint_transfer_not_ready(struct dwc3_ep *dep,
                const struct dwc3_event_depevt *event)
 {
+       /*
+        * During a device-initiated disconnect, a late xferNotReady event can
+        * be generated after the End Transfer command resets the event filter,
+        * but before the controller is halted. Ignore it to prevent a new
+        * transfer from starting.
+        */
+       if (!dep->dwc->connected)
+               return;
+
        dwc3_gadget_endpoint_frame_from_event(dep, event);
 
        /*