]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
RISC-V: KVM: Don't treat SBI HFENCE calls as NOPs
authorAnup Patel <apatel@ventanamicro.com>
Thu, 5 Jun 2025 06:14:47 +0000 (11:44 +0530)
committerAnup Patel <anup@brainfault.org>
Tue, 17 Jun 2025 04:48:40 +0000 (10:18 +0530)
The SBI specification clearly states that SBI HFENCE calls should
return SBI_ERR_NOT_SUPPORTED when one of the target hart doesn’t
support hypervisor extension (aka nested virtualization in-case
of KVM RISC-V).

Fixes: c7fa3c48de86 ("RISC-V: KVM: Treat SBI HFENCE calls as NOPs")
Reviewed-by: Atish Patra <atishp@rivosinc.com>
Signed-off-by: Anup Patel <apatel@ventanamicro.com>
Link: https://lore.kernel.org/r/20250605061458.196003-3-apatel@ventanamicro.com
Signed-off-by: Anup Patel <anup@brainfault.org>
arch/riscv/kvm/vcpu_sbi_replace.c

index 9752d2ffff6834ffc434ad4c8d55640f66b7bc2e..b17fad091babdc3446521656db82e958329a1db3 100644 (file)
@@ -127,9 +127,9 @@ static int kvm_sbi_ext_rfence_handler(struct kvm_vcpu *vcpu, struct kvm_run *run
        case SBI_EXT_RFENCE_REMOTE_HFENCE_VVMA_ASID:
                /*
                 * Until nested virtualization is implemented, the
-                * SBI HFENCE calls should be treated as NOPs
+                * SBI HFENCE calls should return not supported
+                * hence fallthrough.
                 */
-               break;
        default:
                retdata->err_val = SBI_ERR_NOT_SUPPORTED;
        }