branch: test for failures while renaming branches

When we introduced replace_each_worktree_head_symref() in 70999e9cec
(branch -m: update all per-worktree HEADs, 2016-03-27), we implemented a
best effort approach.

If we are asked to rename a branch that is simultaneously checked out in
multiple worktrees, we try to update all of those worktrees.  If we fail
updating any of them, we die() as a signal that something has gone
wrong.  However, at this point, the branch ref has already been renamed
and also updated the HEADs of the successfully updated worktrees.
Despite returning an error, we do not try to rollback those changes.

Let's add a test to notice if we change this behavior in the future.

In next commits we will change replace_each_worktree_head_symref() to
work more closely with its only caller, copy_or_rename_branch().  Let's
move the former closer to its caller, to facilitate those changes.

Signed-off-by: Rubén Justo <rjusto@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/branch.c b/branch.c
index e5614b53b3699d9fc08d41135b16a4a875b0fc68..f64062be71facf76fba819b036562a513e6ba1b1 100644 (file)
--- a/branch.c
+++ b/branch.c
@@ -830,30 +830,3 @@ void die_if_checked_out(const char *branch, int ignore_current_worktree)
 
        free_worktrees(worktrees);
 }
-
-int replace_each_worktree_head_symref(const char *oldref, const char *newref,
-                                     const char *logmsg)
-{
-       int ret = 0;
-       struct worktree **worktrees = get_worktrees();
-       int i;
-
-       for (i = 0; worktrees[i]; i++) {
-               struct ref_store *refs;
-
-               if (worktrees[i]->is_detached)
-                       continue;
-               if (!worktrees[i]->head_ref)
-                       continue;
-               if (strcmp(oldref, worktrees[i]->head_ref))
-                       continue;
-
-               refs = get_worktree_ref_store(worktrees[i]);
-               if (refs_create_symref(refs, "HEAD", newref, logmsg))
-                       ret = error(_("HEAD of working tree %s is not updated"),
-                                   worktrees[i]->path);
-       }
-
-       free_worktrees(worktrees);
-       return ret;
-}

diff --git a/branch.h b/branch.h
index ef56103c050fa09d6087e2bade7f24240d79ae04..30c01aed73d7b7751b87cfb4c5cd55387c8b8bb9 100644 (file)
--- a/branch.h
+++ b/branch.h
@@ -155,12 +155,4 @@ int read_branch_desc(struct strbuf *, const char *branch_name);
  */
 void die_if_checked_out(const char *branch, int ignore_current_worktree);
 
-/*
- * Update all per-worktree HEADs pointing at the old ref to point the new ref.
- * This will be used when renaming a branch. Returns 0 if successful, non-zero
- * otherwise.
- */
-int replace_each_worktree_head_symref(const char *oldref, const char *newref,
-                                     const char *logmsg);
-
 #endif

diff --git a/builtin/branch.c b/builtin/branch.c
index f63fd45edb96b513c24e1a9cd7c8a55e5a5f7b13..c7ace2f2da45c8cebb98433be80f38677adf49c7 100644 (file)
--- a/builtin/branch.c
+++ b/builtin/branch.c
@@ -509,6 +509,38 @@ static void reject_rebase_or_bisect_branch(const char *target)
        free_worktrees(worktrees);
 }
 
+/*
+ * Update all per-worktree HEADs pointing at the old ref to point the new ref.
+ * This will be used when renaming a branch. Returns 0 if successful, non-zero
+ * otherwise.
+ */
+static int replace_each_worktree_head_symref(const char *oldref, const char *newref,
+                                            const char *logmsg)
+{
+       int ret = 0;
+       struct worktree **worktrees = get_worktrees();
+       int i;
+
+       for (i = 0; worktrees[i]; i++) {
+               struct ref_store *refs;
+
+               if (worktrees[i]->is_detached)
+                       continue;
+               if (!worktrees[i]->head_ref)
+                       continue;
+               if (strcmp(oldref, worktrees[i]->head_ref))
+                       continue;
+
+               refs = get_worktree_ref_store(worktrees[i]);
+               if (refs_create_symref(refs, "HEAD", newref, logmsg))
+                       ret = error(_("HEAD of working tree %s is not updated"),
+                                   worktrees[i]->path);
+       }
+
+       free_worktrees(worktrees);
+       return ret;
+}
+
 static void copy_or_rename_branch(const char *oldname, const char *newname, int copy, int force)
 {
        struct strbuf oldref = STRBUF_INIT, newref = STRBUF_INIT, logmsg = STRBUF_INIT;

diff --git a/t/t3200-branch.sh b/t/t3200-branch.sh
index 5a169b68d6af4d3db62e88dcdc4fb765ee5232a6..6b8b59f15e8ac647417daaf3f9d9019c9cb2c836 100755 (executable)
--- a/t/t3200-branch.sh
+++ b/t/t3200-branch.sh
@@ -239,6 +239,21 @@ test_expect_success 'git branch -M baz bam should succeed when baz is checked ou
        git worktree prune
 '
 
+test_expect_success 'git branch -M fails if updating any linked working tree fails' '
+       git worktree add -b baz bazdir1 &&
+       git worktree add -f bazdir2 baz &&
+       touch .git/worktrees/bazdir1/HEAD.lock &&
+       test_must_fail git branch -M baz bam &&
+       test $(git -C bazdir2 rev-parse --abbrev-ref HEAD) = bam &&
+       git branch -M bam baz &&
+       rm .git/worktrees/bazdir1/HEAD.lock &&
+       touch .git/worktrees/bazdir2/HEAD.lock &&
+       test_must_fail git branch -M baz bam &&
+       test $(git -C bazdir1 rev-parse --abbrev-ref HEAD) = bam &&
+       rm -rf bazdir1 bazdir2 &&
+       git worktree prune
+'
+
 test_expect_success 'git branch -M baz bam should succeed within a worktree in which baz is checked out' '
        git checkout -b baz &&
        git worktree add -f bazdir baz &&