]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/imagination: Use new generic compatible string
authorMatt Coster <matt.coster@imgtec.com>
Thu, 10 Apr 2025 09:55:03 +0000 (10:55 +0100)
committerMatt Coster <matt.coster@imgtec.com>
Tue, 15 Apr 2025 11:21:50 +0000 (12:21 +0100)
Follow-on from the companion dt-bindings change ("dt-bindings: gpu: img:
More explicit compatible strings"), deprecating "img,img-axe" in favour of
the more explicit combination of "img,img-rogue" and "img,img-axe-1-16m".

Since all relevant details are interrogated from the device at runtime,
we can match on the generic "img,img-rogue" and avoid adding more entries
with NULL data members (barring hardware quirks).

Reviewed-by: Frank Binns <frank.binns@imgtec.com>
Link: https://lore.kernel.org/r/20250410-sets-bxs-4-64-patch-v1-v6-4-eda620c5865f@imgtec.com
Signed-off-by: Matt Coster <matt.coster@imgtec.com>
drivers/gpu/drm/imagination/pvr_drv.c

index 0639502137b4431dc23a349476572cc898d1f8d0..3130193f8fffc185e630a293be53374bdc4b7ce0 100644 (file)
@@ -1473,6 +1473,13 @@ static void pvr_remove(struct platform_device *plat_dev)
 }
 
 static const struct of_device_id dt_match[] = {
+       { .compatible = "img,img-rogue", .data = NULL },
+
+       /*
+        * This legacy compatible string was introduced early on before the more generic
+        * "img,img-rogue" was added. Keep it around here for compatibility, but never use
+        * "img,img-axe" in new devicetrees.
+        */
        { .compatible = "img,img-axe", .data = NULL },
        {}
 };