]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
staging: iio: adc: ad7816: Correct conditional logic for store mode
authorGabriel Shahrouzi <gshahrouzi@gmail.com>
Mon, 14 Apr 2025 15:40:49 +0000 (11:40 -0400)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Fri, 18 Apr 2025 15:17:37 +0000 (16:17 +0100)
The mode setting logic in ad7816_store_mode was reversed due to
incorrect handling of the strcmp return value. strcmp returns 0 on
match, so the `if (strcmp(buf, "full"))` block executed when the
input was not "full".

This resulted in "full" setting the mode to AD7816_PD (power-down) and
other inputs setting it to AD7816_FULL.

Fix this by checking it against 0 to correctly check for "full" and
"power-down", mapping them to AD7816_FULL and AD7816_PD respectively.

Fixes: 7924425db04a ("staging: iio: adc: new driver for AD7816 devices")
Cc: stable@vger.kernel.org
Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com>
Acked-by: Nuno Sá <nuno.sa@analog.com>
Link: https://lore.kernel.org/stable/20250414152920.467505-1-gshahrouzi%40gmail.com
Link: https://patch.msgid.link/20250414154050.469482-1-gshahrouzi@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/adc/ad7816.c

index 6c14d7bcdd6750908e9a53302d48df5abb7bdbbf..081b17f498638b554633c9cd4d071b2690d5a51a 100644 (file)
@@ -136,7 +136,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
        struct iio_dev *indio_dev = dev_to_iio_dev(dev);
        struct ad7816_chip_info *chip = iio_priv(indio_dev);
 
-       if (strcmp(buf, "full")) {
+       if (strcmp(buf, "full") == 0) {
                gpiod_set_value(chip->rdwr_pin, 1);
                chip->mode = AD7816_FULL;
        } else {