attribs: Improve diagnostics

When looking at the attribs code, I've noticed weird diagnostics
like
int a __attribute__((section ("foo", "bar")));
a.c:1:1: error: wrong number of arguments specified for ‘section’ attribute
    1 | int a __attribute__((section ("foo", "bar")));
      | ^~~
a.c:1:1: note: expected between 1 and 1, found 2
As roughly 50% of attributes that accept any arguments have
spec->min_length == spec->max_length, I think it is worth it to have
separate wording for such common case and just write simpler
a.c:1:1: note: expected 1, found 2

2022-09-23  Jakub Jelinek  <jakub@redhat.com>

	* attribs.cc (decl_attributes): Improve diagnostics, instead of
	saying expected between 1 and 1, found 2 just say expected 1, found 2.

diff --git a/gcc/attribs.cc b/gcc/attribs.cc
index fb89616ff296bfde4a9b05a4cc52b3e1de0bd554..b1f103222aac7ad087b02ad97c4ed4da6ff699f5 100644 (file)
--- a/gcc/attribs.cc
+++ b/gcc/attribs.cc
@@ -737,6 +737,9 @@ decl_attributes (tree *node, tree attributes, int flags,
              if (spec->max_length < 0)
                inform (input_location, "expected %i or more, found %i",
                        spec->min_length, nargs);
+             else if (spec->min_length == spec->max_length)
+               inform (input_location, "expected %i, found %i",
+                       spec->min_length, nargs);
              else
                inform (input_location, "expected between %i and %i, found %i",
                        spec->min_length, spec->max_length, nargs);