Revert and improve fix for FtpClient.cc

diff --git a/src/clients/FtpClient.cc b/src/clients/FtpClient.cc
index 740771e420193ed2a807472d2d02b8a5ef73684d..b496f7582538cef7024a5778ddfa678256eb6053 100644 (file)
--- a/src/clients/FtpClient.cc
+++ b/src/clients/FtpClient.cc
@@ -509,9 +509,10 @@ Ftp::Client::handleEpsvReply(Ip::Address &remoteAddr)
             debugs(9, DBG_IMPORTANT, "WARNING: Server at " << ctrl.conn->remote << " sent unknown protocol negotiation hint: " << buf);
             return sendPassive();
         }
-        /* not reached */
-        // failed(ERR_FTP_FAILURE, 0);
-        // return false;
+        /* coverity[unreachable] */
+        /* safeguard against possible future bugs in above conditions */
+        failed(ERR_FTP_FAILURE, 0);
+        return false;
     }
 
     /*  229 Entering Extended Passive Mode (|||port|) */