don't allow interface implementations to specify override remove override

2007-03-04  Jürg Billeter  <j@bitron.ch>

	* vala/valasemanticanalyzer.vala: don't allow interface implementations
	  to specify override
	* vala/valaconstant.vala, vala/valafield.vala,
	  vala/valaformalparameter.vala, vala/valamethod.vala,
	  vala/valaproperty.vala, vala/valasignal.vala,
	  vala/valavariabledeclarator.vala: remove override from interface
	  implementations

svn path=/trunk/; revision=219

diff --git a/vala/ChangeLog b/vala/ChangeLog
index b78a7665bbde82071a7c40e47aa7743d0bd6b0b3..4438228c45a9f2ad830d5020ca1c65bf75e90f99 100644 (file)
--- a/vala/ChangeLog
+++ b/vala/ChangeLog
@@ -1,3 +1,13 @@
+2007-03-04  Jürg Billeter  <j@bitron.ch>
+
+       * vala/valasemanticanalyzer.vala: don't allow interface implementations
+         to specify override
+       * vala/valaconstant.vala, vala/valafield.vala,
+         vala/valaformalparameter.vala, vala/valamethod.vala,
+         vala/valaproperty.vala, vala/valasignal.vala,
+         vala/valavariabledeclarator.vala: remove override from interface
+         implementations
+
 2007-03-04  Jürg Billeter  <j@bitron.ch>
 
        * vala/parser.y, vala/valainterface.vala,

diff --git a/vala/vala/valaconstant.vala b/vala/vala/valaconstant.vala
index 88a9b401a5c72c676f0608ddf6ddd0aeb156561c..a3a845e24f9d0871db84da4d09134f135d15b903 100644 (file)
--- a/vala/vala/valaconstant.vala
+++ b/vala/vala/valaconstant.vala
@@ -104,11 +104,11 @@ public class Vala.Constant : Member, Lockable {
                return cname;
        }
        
-       public override bool get_lock_used () {
+       public bool get_lock_used () {
                return lock_used;
        }
        
-       public override void set_lock_used (bool used) {
+       public void set_lock_used (bool used) {
                lock_used = used;
        }
 }

diff --git a/vala/vala/valafield.vala b/vala/vala/valafield.vala
index 50168bf4970516b4c6a0f9266cff0af737770576..884de754552005379815bacdefef1ab1e3a75dfb 100644 (file)
--- a/vala/vala/valafield.vala
+++ b/vala/vala/valafield.vala
@@ -141,7 +141,7 @@ public class Vala.Field : Member, Invokable, Lockable {
                }
        }
 
-       public override ref List<weak FormalParameter> get_parameters () {
+       public ref List<weak FormalParameter> get_parameters () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -150,7 +150,7 @@ public class Vala.Field : Member, Invokable, Lockable {
                return cb.get_parameters ();
        }
        
-       public override TypeReference get_return_type () {
+       public TypeReference get_return_type () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -159,15 +159,15 @@ public class Vala.Field : Member, Invokable, Lockable {
                return cb.return_type;
        }
 
-       public override bool is_invokable () {
+       public bool is_invokable () {
                return (type_reference.data_type is Callback);
        }
        
-       public override bool get_lock_used () {
+       public bool get_lock_used () {
                return lock_used;
        }
        
-       public override void set_lock_used (bool used) {
+       public void set_lock_used (bool used) {
                lock_used = used;
        }
 }

diff --git a/vala/vala/valaformalparameter.vala b/vala/vala/valaformalparameter.vala
index c699a185c4f69722d31e8df941033e7342a46c35..4b4d3cf712f9cf7c9a222a035d6887f33708abad 100644 (file)
--- a/vala/vala/valaformalparameter.vala
+++ b/vala/vala/valaformalparameter.vala
@@ -96,7 +96,7 @@ public class Vala.FormalParameter : CodeNode, Invokable {
                visitor.visit_formal_parameter (this);
        }
 
-       public override ref List<weak FormalParameter> get_parameters () {
+       public ref List<weak FormalParameter> get_parameters () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -105,7 +105,7 @@ public class Vala.FormalParameter : CodeNode, Invokable {
                return cb.get_parameters ();
        }
        
-       public override TypeReference get_return_type () {
+       public TypeReference get_return_type () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -114,7 +114,7 @@ public class Vala.FormalParameter : CodeNode, Invokable {
                return cb.return_type;
        }
 
-       public override bool is_invokable () {
+       public bool is_invokable () {
                return (type_reference.data_type is Callback);
        }
 }

diff --git a/vala/vala/valamethod.vala b/vala/vala/valamethod.vala
index fd20e1e8bfcd9098f5da73f4625e5b79fde34759..8569eb7b7e413602d835897dc04f471ad41ce1ec 100644 (file)
--- a/vala/vala/valamethod.vala
+++ b/vala/vala/valamethod.vala
@@ -168,15 +168,15 @@ public class Vala.Method : Member, Invokable {
                parameters.append (param);
        }
        
-       public override ref List<weak FormalParameter> get_parameters () {
+       public ref List<weak FormalParameter> get_parameters () {
                return parameters.copy ();
        }
        
-       public override TypeReference get_return_type () {
+       public TypeReference get_return_type () {
                return return_type;
        }
 
-       public override bool is_invokable () {
+       public bool is_invokable () {
                return true;
        }
        

diff --git a/vala/vala/valaproperty.vala b/vala/vala/valaproperty.vala
index 4d1c759e9a66aac45015c0c486c8b4c9350ac04d..2b0e48fb8c237b24fc8f7309e20ad7aeb5959660 100644 (file)
--- a/vala/vala/valaproperty.vala
+++ b/vala/vala/valaproperty.vala
@@ -155,11 +155,11 @@ public class Vala.Property : Member, Lockable {
                }
        }
        
-       public override bool get_lock_used () {
+       public bool get_lock_used () {
                return lock_used;
        }
        
-       public override void set_lock_used (bool used) {
+       public void set_lock_used (bool used) {
                lock_used = used;
        }
 }

diff --git a/vala/vala/valasemanticanalyzer.vala b/vala/vala/valasemanticanalyzer.vala
index 16942f68fa7fb56f33c410d0ef6a5ae979aa2ad3..240e3cb60a4a63f829bb0baa50e04ff79280fc13 100644 (file)
--- a/vala/vala/valasemanticanalyzer.vala
+++ b/vala/vala/valasemanticanalyzer.vala
@@ -238,10 +238,7 @@ public class Vala.SemanticAnalyzer : CodeVisitor {
                                if (m.is_virtual || m.overrides) {
                                        find_base_class_method (m, (Class) current_symbol.node);
                                        if (m.base_method == null) {
-                                               // FIXME remove check after interface override transition
-                                               if (m.base_interface_method == null) {
-                                                       Report.error (m.source_reference, "%s: no suitable method found to override".printf (m.symbol.get_full_name ()));
-                                               }
+                                               Report.error (m.source_reference, "%s: no suitable method found to override".printf (m.symbol.get_full_name ()));
                                        }
                                }
                        }

diff --git a/vala/vala/valasignal.vala b/vala/vala/valasignal.vala
index fc836e0643fa97bf3105648ea4bec78a0fda7dd0..5e10a2c97efff7e44d023ad043ad86882fc28bb9 100644 (file)
--- a/vala/vala/valasignal.vala
+++ b/vala/vala/valasignal.vala
@@ -77,15 +77,15 @@ public class Vala.Signal : Member, Invokable, Lockable {
                parameters.append (param);
        }
 
-       public override ref List<weak FormalParameter> get_parameters () {
+       public ref List<weak FormalParameter> get_parameters () {
                return parameters.copy ();
        }
        
-       public override TypeReference get_return_type () {
+       public TypeReference get_return_type () {
                return return_type;
        }
 
-       public override bool is_invokable () {
+       public bool is_invokable () {
                return true;
        }
        
@@ -179,11 +179,11 @@ public class Vala.Signal : Member, Invokable, Lockable {
                }
        }
        
-       public override bool get_lock_used () {
+       public bool get_lock_used () {
                return lock_used;
        }
        
-       public override void set_lock_used (bool used) {
+       public void set_lock_used (bool used) {
                lock_used = used;
        }
 }

diff --git a/vala/vala/valavariabledeclarator.vala b/vala/vala/valavariabledeclarator.vala
index a0a134c2a3a9fc86048c070a5da89a62c332d44a..321a5b5d7a63f53ca3ef368eb583e9db0fea82b4 100644 (file)
--- a/vala/vala/valavariabledeclarator.vala
+++ b/vala/vala/valavariabledeclarator.vala
@@ -81,7 +81,7 @@ public class Vala.VariableDeclarator : CodeNode, Invokable {
                visitor.visit_variable_declarator (this);
        }
 
-       public override ref List<weak FormalParameter> get_parameters () {
+       public ref List<weak FormalParameter> get_parameters () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -90,7 +90,7 @@ public class Vala.VariableDeclarator : CodeNode, Invokable {
                return cb.get_parameters ();
        }
        
-       public override TypeReference get_return_type () {
+       public TypeReference get_return_type () {
                if (!is_invokable ()) {
                        return null;
                }
@@ -99,7 +99,7 @@ public class Vala.VariableDeclarator : CodeNode, Invokable {
                return cb.return_type;
        }
 
-       public override bool is_invokable () {
+       public bool is_invokable () {
                return (type_reference.data_type is Callback);
        }