]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
BUG/MINOR: proto-http: Don't forward request body anymore on error
authorChristopher Faulet <cfaulet@haproxy.com>
Tue, 19 Mar 2019 13:55:11 +0000 (14:55 +0100)
committerWilly Tarreau <w@1wt.eu>
Fri, 22 Mar 2019 17:05:50 +0000 (18:05 +0100)
In the commit 93e02d8b7 ("MINOR: proto-http/proto-htx: Make error handling
clearer during data forwarding"), a return clause was removed by error in the
function http_request_forward_body(). This bug seems not having any visible
impact.

This patch must be backported to 1.9.

src/proto_http.c

index 85e007b496310a7f1dba68b3e25b5fe8678fa748..9ba0eb594d8b28e677c4f1a13557ed3fd484d83b 100644 (file)
@@ -3992,6 +3992,7 @@ int http_request_forward_body(struct stream *s, struct channel *req, int an_bit)
                msg->err_state = msg->msg_state;
                msg->msg_state = HTTP_MSG_ERROR;
                http_resync_states(s);
+               return 1;
        }
 
        /* Note that we don't have to send 100-continue back because we don't